Closed AntoineFr closed 1 year ago
@aslafy-z validation successful`
@aslafy-z should we get some tests added as well? And how about changelog file that should be required as well
Hello @rasheedamir , I updated the changelog in 3332fa4 Edit: I also fixed conflicts because another release was published before my PR was merged
For the tests, this PR only adds some simple mappings so I don't know if they would add a lot of value
Also, can you please squash the commits when merging this PR to only keep 1 in main and not all my iterative commits 😄
@rasheedamir I'm aligned with @AntoineFr on that one. I think tests are not necessary for simple mappings like that.
@AntoineFr plz resolve conflicts! and then lets merge @aslafy-z
@rasheedamir the conflicts are gone 🎉
This PR adds support for the following properties in CronJob:
.spec.jobTemplate.spec.activeDeadlineSeconds
.spec.jobTemplate.spec.backoffLimit
.spec.jobTemplate.spec.template.metadata.annotations
.spec.jobTemplate.spec.template.metadata.labels
.spec.jobTemplate.spec.template.spec.topologySpreadConstraints
.spec.jobTemplate.spec.template.spec.securityContext