stakater / application

Generic helm chart for all kind of applications
http://stakater.com
MIT License
202 stars 85 forks source link

feat(cronjob): Add more properties #265

Closed AntoineFr closed 1 year ago

AntoineFr commented 1 year ago

This PR adds support for the following properties in CronJob:

github-actions[bot] commented 1 year ago

@aslafy-z validation successful`

rasheedamir commented 1 year ago

@aslafy-z should we get some tests added as well? And how about changelog file that should be required as well

AntoineFr commented 1 year ago

Hello @rasheedamir , I updated the changelog in 3332fa4 Edit: I also fixed conflicts because another release was published before my PR was merged

For the tests, this PR only adds some simple mappings so I don't know if they would add a lot of value

Also, can you please squash the commits when merging this PR to only keep 1 in main and not all my iterative commits 😄

aslafy-z commented 1 year ago

@rasheedamir I'm aligned with @AntoineFr on that one. I think tests are not necessary for simple mappings like that.

rasheedamir commented 1 year ago

@AntoineFr plz resolve conflicts! and then lets merge @aslafy-z

AntoineFr commented 1 year ago

@rasheedamir the conflicts are gone 🎉