search

stakater / application

Generic helm chart for all kind of applications
http://stakater.com
MIT License
202 stars 85 forks source link

Fix bug with secrets being empty #289

Closed IneyMickey closed 9 months ago

IneyMickey commented 9 months ago

The secret data is empty until I use dollar sign.

Here's my values.yaml example that doesn't work as expected

secret:
  enabled: true
  files:
    credentials:
      SECRET: <my_secret>
IneyMickey commented 9 months ago

@d3adb5 - Could you please take a look?

IneyMickey commented 9 months ago

@aslafy-z - Could you please review and release?

IneyMickey commented 9 months ago

@mustafaStakater - Good day. Can you please take a look?

IneyMickey commented 9 months ago

@aslafy-z Any updates regarding the runner?

aslafy-z commented 9 months ago

I think this can be merged safely without being played within the build workflow. I will proceed and merge. Thank you for your contribution!

aslafy-z commented 9 months ago

It looks like this runner is needed to tag and push updates to Helm repository. Can you please give a look @rasheedamir @mustafaStakater Thank you

mustafaStakater commented 9 months ago

sorry about this, we ll look into it