stake-for-impact / stake-for-impact-contracts

1 stars 0 forks source link

Allow multisig to add new minters of imETH #14

Open olenovyk opened 1 year ago

olenovyk commented 1 year ago

Description

Status quo is that only factory contract is allowed to grant minting rights to newly created vaults. This makes Stake for Impact system completely immutable. But since the system is immutable, it is not possible to upgrade it. But I believe that on current stage of the project, we should be able to update the system. E.g. we want to integrate with another staking provider, or implement different strategy for user's deposits.

The solution will be having an EOA that can assign and renounce to/from factories minter roles of imETH token.

To protect user's vaults from various potential governance attack, there should be a timedelay between the change being deployed by the owner and it being executed.

Acceptance criteria [] Make imETH token Ownable; [] Make sure that there are granMinterRole / renounceMinterRole functions that only owner can call; [] Implement timelock