stake-house / wagyu-key-gen

GNU General Public License v3.0
60 stars 42 forks source link

Withdrawal address should be required #152

Closed wackerow closed 1 year ago

wackerow commented 1 year ago

With Shanghai around the corner, and EIP-4895 ironed out, we should be encouraging new stakers to provide withdrawal credentials upon their initial deposit, to avoid them having to upgrade their credentials from 0x00 to 0x01 in the future.

I've put up a draft PR is up on the Staking Launchpad emphasizing similar behavior as a default workflow

image

I would suggest removing this "Advanced" option, and simply make this required. It will save users time in the long run, and help their security by reducing their need to enter their mnemonic again and generate withdrawal keys. If users really want to have finer control, they can (as of now) still use the staking deposit CLI without providing this flag, and the deposit data will still be generated.