Make providing withdrawal credentials required

stake-house / wagyu-key-gen

GNU General Public License v3.0

60 stars 42 forks source link

Make providing withdrawal credentials required #153

Closed wackerow closed 1 year ago

wackerow commented 1 year ago

Description

Removes the "Advanced" option, making providing a withdrawal address required
Updates tooltip helper text and mentions of "optional"

Screenshot

Related issue

[Fixes #152]

alexpeterson91 commented 1 year ago

I fully agree with this. I actually implemented this same thing (in a slightly less efficient way) on my fork for Gnosis chain about a year ago. Since withdrawal addresses were required from genesis of the gnosis beacon-chain when generating more than one key at a time so it was necessary for Gnosis chain since it existed and it has for Ethereum even longer just not since genesis. Definitely happy to see someone else thinking the same and submitting this PR. 👍

wackerow commented 1 year ago

Also noting that the staking-deposit-cli that Wagyu wraps currently has a draft PR up to make the withdrawal address required: https://github.com/ethereum/staking-deposit-cli/pull/315