stake-house / wagyu-key-gen

GNU General Public License v3.0
60 stars 42 forks source link

Warn user if they are connected to the internet? #172

Closed FuzzyDream closed 5 months ago

FuzzyDream commented 1 year ago

The GUI currently suggests that the user disconnect from the internet before proceeding. What about also detecting if the user ignored this advice, or accidentally re-enabled the internet after disabling it?

Suggestion, if the user is connected to the internet, and they proceed to try to generate keys on main net (not test net), they should be warned that they are still online.

On multiple occasions I myself have turned off wifi and then accidentally re-enabled it. Once this happened when I turned on air-drop, which I did not realize would automatically turn on my wi-fi. I also had this old netbook which would try to be helpful by turning on wi-fi without me taking any action sometimes. In both cases on both computers I was actively TRYING to stay offline for security reasons, so I know firsthand that accidental internet is not a completely unrealistic worry.

I know this change will probably annoy testers who will have to click through the warning every time, but I personally think a GUI like this should be written with the most dense and careless users in mind.