search

stakervali / grin-wishlist

Wishlist for grin features
0 stars 1 forks source link

Display slatepacks as QR codes in CLI #12

Open stakervali opened 2 years ago

stakervali commented 2 years ago
cliik commented 2 years ago

Hi, I am interested in taking on this wishlist item. I've already done similar work in the CLI: https://github.com/mimblewimble/grin-wallet/pull/650

Is anyone else already working on this? If not, what are the requirements for this feature? My initial impression is this is just a CLI change, so no need to update the owner API. If so, I think this should be a painless addition.

stakervali commented 2 years ago

Hi @cliik, AFAIK there is no bounty for this item nor anyone working on this.

cliik commented 2 years ago

Hi @cliik, AFAIK there is no bounty for this item nor anyone working on this.

Ok great. I will look into this and may take it on next week, depending on my schedule.

cliik commented 2 years ago

@stakervali does this satisfy your request?

https://github.com/mimblewimble/grin-wallet/pull/655

cliik commented 2 years ago

@stakervali should this wishlist item be moved to "in progress" on https://grincc.mw/projects? I don't need a bounty, but it is in progress none the less :smile:

stakervali commented 2 years ago

Hi @cliik If you open a forum post, I can add link. Also do milestones look good below?

(Or implementation of QR code display in grin-wallet ?)

image

cliik commented 2 years ago

@stakervali The milestones look fine, but one small change to the description: This project aims to improve 'grin-wallet CLI', not 'Grin++ project.

If you open a forum post, I can add link.

What do you want me to ask in the forums? Just to ask people to review the PR and submit feedback?

stakervali commented 2 years ago

Hi @cliik, sorry for late reply, I forgot to reply and close the tab with other 100 tabs I opened. I meant a small post at forum for informing community about your work. I updated grincc.mw, added this to finished projects category.