search

stakevrun / frontend

Non-custodial Ethereum staking service
https://vrün.com
GNU General Public License v3.0
1 stars 0 forks source link

DB duplicating charging days #310

Closed frankmchugh closed 2 months ago

frankmchugh commented 3 months ago

I deleted the old issue by accident. But check instance given by Steely in Vrun chat a few days ago

xrchz commented 2 months ago

I haven't been able to find the right message - do you have a link to it?

xrchz commented 2 months ago

Got it here: https://discord.com/channels/1216708060832075806/1216708061507616821/1249362834396025012

xrchz commented 2 months ago

Notes to myself: https://fee.xn--vrn-ioa.com/17000/0xe72EC6a6D5d99A615e1D712B269E611331783FC8/0xa01b3b4dca5336666b066768d847f58365e08411218e0f06ef35b7699eb33f7e76186e8c139b9df05aa503cfbdbf0cc7/charges -- this is the raw fee data for that duplicate charge issue Looks like because of the stop and start on the same day, that day is included in two ranges (as the last day of one range, and the first day of the next) I guess the fee server should do some merging in that case? maybe merge the whole range into a single range? yeah I think that's the right move

xrchz commented 2 months ago

I think this is addressed by https://github.com/stakevrun/fee/commit/99ea4b7c1e5893436d01873d4ab4f9a4a70e94f0

xrchz commented 2 months ago

Confirmed fixed here https://discord.com/channels/1216708060832075806/1216708061507616821/1253965199506145291