search

stakewise / helm-charts

Curated StakeWise Helm Charts for Kubernetes
Other
34 stars 27 forks source link

Should liveness and readiness probes be disabled by default? #392

Open baizele opened 1 year ago

baizele commented 1 year ago

Noting this comment, should the probes be disabled by default? I ran into an issue where my CL client couldn't connect to the EL client because EL wasn't discoverable due to its readiness probe failing.

In what scenarios is it preferable to have this enabled? Would that be after the client has fully synced?

antares-sw commented 1 year ago

@baizele At the first deployment of the chart, it is recommended to disable the probes so that the pods do not restart, after the clients are fully synced, they can be turned back on to perform checks.

ebaizel commented 1 year ago

Thanks @antares-sw. Would it make sense then to have the default value be disabled since most apps will need this disabled as they do their initial sync?