nethermind: adding secret name override

kaplanmaxe commented 4 months ago

Big fan of this repo!

The current way secrets are handled in this repo is not the most ideal in my opinion. While the docs show an example of specifying the JWT token via an environment variable (which is not bad security wise), if one wanted to track their values.yaml file in git, the current chart requires .Values.global.JWTSecret to be tracked in code.

Additionally, it's very common for people to use external secret providers like Hashicorp Vault (which I have seen Stakewise supports in some areas already). To do this, one could use a SecretProviderClass (or the vault injector obviously).

This PR allows for:

The chart to reference a secret that is not managed by the chart
Adding additional volumes
Adding additional volumeMounts

antares-sw commented 3 months ago

Hey @kaplanmaxe, thanks for the PR, please up chart version here: https://github.com/stakewise/helm-charts/blob/main/charts/nethermind/Chart.yaml#L5

kaplanmaxe commented 3 months ago

done!

stakewise / helm-charts

nethermind: adding secret name override #556