Closed irriden closed 7 months ago
ok... to recap...
Solution possibilities
This works well for single signer, but doesn't work well in case a signer goes offline at this same point.
Broker tries the other signer, and keeps trying to send lss message, signer receives it, restores from sd card, but gets an E (297856) sphinx_key::core::events: Invalid server hmac
because the message it just restored from the sd card doesn't match.
Yes... this is what i was thinking yesterday... we need to refactor the way broker switches between signers. But lets merge the latest VLS stuff first
Fixed in 80a23cb5f07bebc29e9bd0195423020f223a3a40
Key is the following: in the case where signer crashes before sending an LSS response, broker shouldn't try the LSS response again and again, but rather go back to sending the previous VLS message, and attempt to restart the show at that point.
Signer had a problem and likely needed a restart while broker executed these lines of code:
https://github.com/stakwork/sphinx-key/blob/6516b208a5074a4d858fde721f1323283dae848a/broker/src/looper.rs#L170-L176
Broker is then stuck trying to send the message on topic
lss-msg
, and signer does not respond.Manually restarting the broker fixed the issue temporarily.