stakwork / sphinx-key

Lightning hardware signer on ESP32
29 stars 1 forks source link

sphinx-key: save previous msgs to sd card #127

Closed irriden closed 1 year ago

irriden commented 1 year ago

Closes #120

It turns out that from a performance point of view, this is just as performant as storing the previous messages on flash storage.

The huge benefit though is that flash storage is only 16kB, whereas sd card storage is GB's.

irriden commented 1 year ago

Just realized should I be using our FsKVVStore instead ? If there's a way then we could get rid of FsPersister completely.

Evanfeenstra commented 1 year ago

Yes… you should be able to run put and get directly on the FsKVVStore (without needing to impl specific functions for it)

irriden commented 1 year ago

Ok all good will do.