stakwork / sphinx-mac

Sphinx app for mac desktop
MIT License
4 stars 16 forks source link

Tribe Member section Implementation #371

Closed Korede612 closed 2 months ago

Korede612 commented 2 months ago

Pull Request Title

New view for TRIBE MEMBERS in the right panel of the chat view https://github.com/stakwork/sphinx-mac/issues/365

Description

This pull request addresses the Create New view for TRIBE MEMBERS in the right panel of the chat view in Issue https://github.com/stakwork/sphinx-mac/issues/365.

The following are the addressed issues:

Changes Made

tomastiminskas commented 2 months ago

@Korede612 the changes look and work great. Just a few adjustments to make:

  1. The tribe members are showing in the wrong order. The should be alphabetically ordered starting from the top but they are showing in reverse

    Screenshot 2024-05-02 at 10 25 00 AM
  2. Initials color is wrong, it should be a grey color (that you can take from iOS project) but it's showing white

  3. Let's align the initial label with the back arrow on the header (right now there's a small difference)

  4. For members without an image you should show the initials with the user color (you should use ChatSmallAvatarView class which contains both an image and a view with initials and a background color). If you add one view of that type on each row, then you can call a method on the class with an optional image, an alias and a color)

  5. Finally as you might have seen, iOS has the ability to delete a member from the tribe swiping in the row and then tapping on delete button. We don't want a swipe to delete gesture on Mac, but we can just show the delete icon on the right side of each row (tint color secondaryText) and add the logic when tapping on it. Once a member has been deleted you should reload the entire table since the initials logic will be broken otherwise.

Let me know if the changes make sense

Korede612 commented 2 months ago

@tomastiminskas the changes requested makes sense