Closed Korede612 closed 1 month ago
@Korede612 I was reviewing the videos and they look great. The only thing that I’m not sure it’s right is the horizontal margin between the selected mention box and the container box. it seems smaller than the one on the designs, but can’t be sure actually since I didn’t check the code yet.
Also top and bottom margins seems a bit wrong. If you see this screenshot from your video you will see there’s a bigger margin on the top than on the bottom (the bottom row image is almost touching the bottom edge of the container, but the top row has a margin with the top of the container). They should be vertically centered so both the bottom and the top margin are the same.
The colors look different but I guess it's because of the video (please double check all color hex codes)
Finally I would like videos of a mention in a second or third line of the message (like a multiline message in the field and a mention not in the first line) and also writing enough letters so the suggestions are less than 3 to see how the box height adapts to its content.
Thanks in advance
@Korede612 ok great. I will try to review the code between today and tomorrow and let you know, thanks!
Pull Request Title
Mentions autocomplete view redesigns https://github.com/stakwork/sphinx-mac/issues/398
Description
This pull request addresses the Mentions autocomplete view redesigns in Issue https://github.com/stakwork/sphinx-mac/issues/398.
The following are the addressed issues:
Changes Made
Link: