Closed Korede612 closed 3 weeks ago
@Korede612 I just watched the videos and there are some things to fix:
configureForKeyboard(with message: TransactionMessage...
method or duplicate the view and use the new one with the UI changes just for the message fieldThanks in advance
@Korede612 I suggested duplicating the NewReplyView to preserve the original one as it was. But it seems you duplicated it from the state where you were but you didn't reverted the changes you had done in the original view, so the reply inside each message bubble seems to be affected by your changes.
In the other hand I asked to remove the bottom line separator, but I don't think you added to top line separator (as requested in the previous feedback) as it's shown in the designs. Please let me know if I'm wrong and as soon as you do the following changes I will review the code and merge.
Thanks in advance
Thanks for your understanding
@Korede612 I merged into a branch on my side and applied the fixes there in case you want to review. The branch name is test-flight-reply-bar-redesign
. Here are the details of the things I had to fixed:
Please if you have time reviewed them to avoid similar issues in the future:
Please check this Figma instructions ticket: https://github.com/stakwork/sphinx-ios/issues/435
Pull Request Title
Reply Bar Redesign https://github.com/stakwork/sphinx-mac/issues/402
Description
This pull request addresses the Reply Bar Redesign in Issue https://github.com/stakwork/sphinx-mac/issues/402.
The following are the addressed issues:
Changes Made
Link