search

stakwork / sphinx-tribes-frontend

Frontend for sphinx tribes and bounties. The bounty platform that pays out in bitcoin. Sign up with Sphinx Chat, complete a bounty, and earn bitcoin! Go to our website for available bounties.
https://community.sphinx.chat/bounties
12 stars 42 forks source link

Searching state is not clear when switch to people cards page from person detail page #152

Closed Fog3211 closed 8 months ago

Fog3211 commented 8 months ago

Describe the bug When performing search filtering on the user details page, if the search criteria is not cleared and the "back" button is clicked to return to the previous /p page, the searching conditions are not reset.

To Reproduce Steps to reproduce the behavior:

  1. Go to people page
  2. Search user by some keywords
  3. Click Back button without clear the search keywords
  4. See the wrong search result

https://github.com/stakwork/sphinx-tribes-frontend/assets/23151576/1dd1a603-a4ae-415d-a635-26eee377a15f

Expected behavior Searching conditions should be reset when switch to people cards page

Desktop (please complete the following information):

Acceptance Criteria

ecurrencyhodler commented 8 months ago

This should be fixed on staging. If it's not, ping me and we can reopen. Thanks for QA-ing the site!

Fog3211 commented 8 months ago

@ecurrencyhodler It appears that the issue still persists in the staging environment. To rule out the possibility of the problem being caused by incomplete code deployment to the staging environment, I replicated the issue locally using the latest code from the master branch, and the result was the same.

https://github.com/stakwork/sphinx-tribes-frontend/assets/23151576/95d99e38-2bf2-45bc-85be-117fc30b3297

Fog3211 commented 8 months ago

I found the link to the issue you mentioned earlier, and it appears that in the previous bug fix, only the value in the search bar was cleared, but it did not trigger an update of the search results.

https://github.com/stakwork/sphinx-tribes-frontend/pull/18#issuecomment-1913958171

Additionally, I'm not the only one who has noticed this issue. I saw that MahtabBukhari also raised this issue #99 after the pull request was made.

ecurrencyhodler commented 8 months ago

Let's put a pause on this right now. Search is a complicated feature that we are trying to debug fully with Yegor. We can revisit after his changes get merged.

vishnu552 commented 8 months ago

@ecurrencyhodler Is this issue available? If it is,can I take it?

ecurrencyhodler commented 8 months ago

Looks like it's been fixed on staging closing this issue out.

https://github.com/stakwork/sphinx-tribes-frontend/assets/32662508/14024f87-1d64-430c-8ac0-f8adeaa41a2f