Fixed(org-fields): Organization Creation Extra Whitespace

stakwork / sphinx-tribes-frontend

Frontend for sphinx tribes and bounties. The bounty platform that pays out in bitcoin. Sign up with Sphinx Chat, complete a bounty, and earn bitcoin! Go to our website for available bounties.

https://community.sphinx.chat/bounties

12 stars 42 forks source link

Fixed(org-fields): Organization Creation Extra Whitespace #311

Closed aliraza556 closed 8 months ago

aliraza556 commented 8 months ago

Describe your changes

An org can only be created if there is a text character in the name. In other words, an org name with only spaces shouldn't be created.

Issue ticket number and link:

Ticket Number: [ 267 ]
Link: [ https://github.com/stakwork/sphinx-tribes-frontend/issues/267 ]

Evidence:

Please see the attached video as evidence. https://www.loom.com/share/dfda281deb4e41dd866d3d938db3e04b

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] Bug fix (non-breaking change which fixes an issue)
[x] I have tested on Chrome
[x] I have added unit tests for both tickets.
[x] I have provided a recording.

aliraza556 commented 8 months ago

Hi @kevkevinpal, Please review this PR.

aliraza556 commented 8 months ago

Hi @kevkevinpal I did't change anything in this file src/people/widgetViews/__tests__/AddUserModal.spec.tsx

aliraza556 commented 8 months ago

HI @kevkevinpal, I think the limit issue! Jest worker encountered 4 child process exceptions, exceeding retry limit. Please check it. Locally unit test is pass

aliraza556 commented 8 months ago

HI @ecurrencyhodler, I think the limit issue! Jest worker encountered 4 child process exceptions, exceeding retry limit. Please check it. Locally unit test is pass

aliraza556 commented 8 months ago

Hi @elraphty, @ecurrencyhodler, @kevkevinpal, after this PR is merged, the unit tests are failing in the newly created PRs. Kindly check them. https://github.com/stakwork/sphinx-tribes-frontend/pull/257/files#diff-d2379ee3c7109fbea9ce7dcc4b95c7da14264dbebbe10cf51aa889b1121c6af6

kevkevinpal commented 8 months ago

Hi @elraphty, @ecurrencyhodler, @kevkevinpal, after this PR is merged, the unit tests are failing in the newly created PRs. Kindly check them. https://github.com/stakwork/sphinx-tribes-frontend/pull/257/files#diff-d2379ee3c7109fbea9ce7dcc4b95c7da14264dbebbe10cf51aa889b1121c6af6

yea I can take a look not sure why its failing since it was passing in that PR, maybe its an issue with the network connectivity of the machine github is using to run the action?

kevkevinpal commented 8 months ago

I pushed 830b66d6c1e201e7840b46c7aed33d2a66a6a46f to see if it'd fix the unit tests

kevkevinpal commented 8 months ago

woohoo the tests are passing, going to review this PR then merge and rebase the other ones

Thanks @aliraza556 for showing me where the failure was

ecurrencyhodler commented 8 months ago

Tested and paid 250k! Increased it 50k for helping to debug the test: https://community.sphinx.chat/bounty/1558