stakwork / sphinx-tribes-frontend

Frontend for sphinx tribes and bounties. The bounty platform that pays out in bitcoin. Sign up with Sphinx Chat, complete a bounty, and earn bitcoin! Go to our website for available bounties.

https://community.sphinx.chat/bounties

12 stars 42 forks source link

Feature: Current month selection for admin date dropdown #516

Closed Vayras closed 4 months ago

Vayras commented 4 months ago

Describe your changes

Added the current month selection for the admin date dropdown

Issue ticket number and link

513

loom video for reference

https://www.loom.com/share/e79c791053e14a2fad415866db6f9a33

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have tested on Chrome and Firefox
[x] I have tested on a mobile device
[x] I have provided a screenshot or recording of changes in my PR if there were updates to the frontend
[x] I have updated the test cases

Vayras commented 4 months ago

Hey! @elraphty can I get a review on this

elraphty commented 4 months ago

Hey! @elraphty can I get a review on this

@Vayras When I click on Current Month the dropdown text changes to May 14 Days

Vayras commented 4 months ago

@elraphty I have added the days indicator so that the user can know the data is of how many days even in the current month

So like today is May 14 so it will show May( 14 days) on drop-down

And 30 Apr - 14 May 2024 on the left wrapper

Let me know your thoughts on this

elraphty commented 4 months ago

@elraphty I have added the days indicator so that the user can know the data is of how many days even in the current month

So like today is May 14 so it will show May( 14 days) on drop-down

And 30 Apr - 14 May 2024 on the left wrapper

Let me know your thoughts on this

@fvalentiner Is this okay with you?

fvalentiner commented 4 months ago

@elraphty why not just put 'Current Month'. Is the label hardcoded to 'x Days'?

elraphty commented 4 months ago

@elraphty why not just put 'Current Month'. Is the label hardcoded to 'x Days'?

Okay, @Vayras Leave it as Current Month, it is descriptive enough.

Vayras commented 4 months ago

@elraphty why not just put 'Current Month'. Is the label hardcoded to 'x Days'?

@fvalentiner the label is dynamic, depends on the day of the month

Vayras commented 4 months ago

@elraphty why not just put 'Current Month'. Is the label hardcoded to 'x Days'?

Okay, @Vayras Leave it as Current Month, it is descriptive enough.

Sure will do that

Vayras commented 4 months ago

@elraphty @fvalentiner made the changes

elraphty commented 4 months ago

@elraphty @fvalentiner made the changes

@Vayras Please the text should be Current Month and not the current month's name e.g May

Vayras commented 4 months ago

@elraphty @fvalentiner made the changes

@Vayras Please the text should be Current Month and not the current month's name e.g May

Got it, my bad

Vayras commented 4 months ago

@elraphty changed the label to current month, Thanks