search

stakwork / sphinx-tribes-frontend

Frontend for sphinx tribes and bounties. The bounty platform that pays out in bitcoin. Sign up with Sphinx Chat, complete a bounty, and earn bitcoin! Go to our website for available bounties.
https://community.sphinx.chat/bounties
12 stars 42 forks source link

[Bug] Investigate V2 Encoding not deploying correctly on Staging #646

Open humansinstitute opened 1 week ago

humansinstitute commented 1 week ago

Follow up integration bug on https://github.com/stakwork/sphinx-tribes-frontend/issues/635 On Merge of https://github.com/stakwork/sphinx-tribes-frontend/pull/640 the Testing on Staging is failing as the copied pubkey is being returned with the corrupt style of encoding. 

- Observed On Staging  ->  <part1>:<part2>_<part3>    
- Expected / Correct      ->  <part1>_<part2>_<part3>
aliraza556 commented 1 week ago

@humansinstitute, Please assign me?

saithsab877 commented 1 week ago

@humansinstitute, assign me?

saithsab877 commented 1 week ago

Hi @humansinstitute,

Please check the demo:

https://www.loom.com/share/1a55f79efdf04e06a187f3cba30b7f9c

Currently, the V2 pubkey is correctly encoded on the staging side. Once the changes are merged and a new release is made (e.g., https://github.com/stakwork/sphinx-tribes-frontend/releases/tag/v0.0.34 ), you can verify that the V2 pubkey is reflected correctly here: https://people-test.sphinx.chat/p/csk586cnuku6oosk3r90/workspaces

Hi @elraphty, could you please release the new changes on the frontend side?

humansinstitute commented 4 days ago

@elraphty Am I missing something here?

The PR is merged and correctly built, but when I test in staging I don't see this behaivour.

Everything other bug where we've merged into main is then rebuilt and deployed on staging for testing without needing to be tagged as a release, so I don't see why this would be different?

Two question:

  1. Am I missing something here about the release process - I expect this should be available in staging?
  2. Can you review https://github.com/stakwork/sphinx-tribes-frontend/pull/640 and see if I'm missing with the logic and why this may not work on staging, but appears correct on Localhost?
elraphty commented 4 days ago

@elraphty Am I missing something here?

The PR is merged and correctly built, but when I test in staging I don't see this behaivour.

Everything other bug where we've merged into main is then rebuilt and deployed on staging for testing without needing to be tagged as a release, so I don't see why this would be different?

Two question:

  1. Am I missing something here about the release process - I expect this should be available in staging?
  2. Can you review Fix: Update Sphinx Links with Correct V2 Pubkey Encoding for Adding People from Registry #640 and see if I'm missing with the logic and why this may not work on staging, but appears correct on Localhost?

Okay, I will take a look.

elraphty commented 4 days ago

2. Fix: Update Sphinx Links with Correct V2 Pubkey Encoding for Adding People from Registry #640

@humansinstitute, I tested this on people-test.sphinx.chat, it worked for V2 users