search

stakwork / sphinx-tribes-frontend

Frontend for sphinx tribes and bounties. The bounty platform that pays out in bitcoin. Sign up with Sphinx Chat, complete a bounty, and earn bitcoin! Go to our website for available bounties.
https://community.sphinx.chat/bounties
12 stars 42 forks source link

JS crash when trying to edit an old bounty #68

Closed Evanfeenstra closed 8 months ago

Evanfeenstra commented 8 months ago

Describe the bug JS crash when opening an old bounty. Some data must be missing. JS should never run .map or similar functions on an array that might be undefined.

Screenshot 2024-01-29 at 8 41 44 AM
VividhPandey003 commented 8 months ago

Oh this is an issue I've created earlier - https://github.com/stakwork/sphinx-tribes/issues/1365

ChetanKarwa commented 8 months ago

@ecurrencyhodler Assign this to me please

Evanfeenstra commented 8 months ago

In my case its due to the "type" of the bounty being wanted_coding_task when actually that is not a valid "type"

Screenshot 2024-01-29 at 8 47 59 AM Screenshot 2024-01-29 at 8 48 07 AM
VividhPandey003 commented 8 months ago

Wait actually it might be the same issue. Uum could you maybe check if these bounties are visible to you and if this is the same issue you're talking about

https://people.sphinx.chat/bounty/75 , https://people.sphinx.chat/bounty/252

Evanfeenstra commented 8 months ago

i fixed my error with a DB query

VividhPandey003 commented 8 months ago

i fixed my error with a DB query

Oh Okay. Thanks for the information

ecurrencyhodler commented 8 months ago

@VividhPandey003 I do see the bounties. I think I'm going to do a partial payout for your work and close your PR unless your PR fixes something else. Sorry about the confusion and thanks for your work.

This was something we ended fixing as part of a larger issue.

VividhPandey003 commented 8 months ago

@ecurrencyhodler Hey no issues. This platform is not just about earning bounties for me. I'd love to make meaningful contributions and since the issue now seems fine i guess we could close it.

ecurrencyhodler commented 8 months ago

Thanks vividh. I'm still going to pay you out partially.

VividhPandey003 commented 8 months ago

Thanks a lot @ecurrencyhodler.

@Evanfeenstra I am new to Js/Ts. I'd really love to know how you derived this conclusion.

When I saw the issue I thought that the issue is that I just need to tackle undefined cases thus I updated the code by using alternatives for map.

You had recently discovered the bug and seemed to fix it in no time. I would want such debugging skills. Would you mind sharing how you fixed it?