Hide tribe button if no tribe is attached to a bounty

stakwork / sphinx-tribes

Backend for sphinx tribes and bounties. The bounty platform pays out in bitcoin. Sign up with Sphinx Chat, complete a bounty, and earn bitcoin! Go to our website for available bounties.

https://community.sphinx.chat/bounties

33 stars 60 forks source link

Hide tribe button if no tribe is attached to a bounty #1209

Closed kevkevinpal closed 9 months ago

kevkevinpal commented 10 months ago

Describe the bug Currently if a tribe is tied to a bounty, I can click the button and it takes me nowhere Screenshot 2023-12-28 at 12 24 08 PM concise description of what the bug is. Include a screenshot or recording if you can.

To Reproduce Steps to reproduce the behavior:

Click on bounty with no tribe attached

Expected behavior If no tribe is associated with a ticket, the tribe should not be displayed for both desktop and mobile

Acceptance Criteria

[ ] I have tested on Chrome desktop
[ ] I have posted a screenshot or video if it is a change in the front end
[ ] Create component test that asserts if no tribe is associated with a bounty, then tribe button will not be displayed

gouravmpk commented 10 months ago

@kevkevinpal Should it be clickable ? If no tribes attached ?

kevkevinpal commented 10 months ago

@kevkevinpal Should it be clickable ? If no tribes attached ?

It should not be clickable and greyed out similar to what we do with the delete button

gouravmpk commented 10 months ago

Okay I can take that if possible !!

kevkevinpal commented 10 months ago

Okay I can take that if possible !!

Don't think a bounty is up for it yet but will assign when one is created

aliraza556 commented 9 months ago

Hi @ecurrencyhodler,

This bounty is available. If it is available, please assign it to me.

ecurrencyhodler commented 9 months ago

Ali this is yours.

gouravmpk commented 9 months ago

@ecurrencyhodler I asked for this one first

ecurrencyhodler commented 9 months ago

Hey @gouravmpk you are right you did. But you already have 2 bounties and ali didn't have any. So I decided to give it to him. Hope you understand.

ecurrencyhodler commented 9 months ago

@aliraza556 do you have an update on this issue?

aliraza556 commented 9 months ago

@ecurrencyhodler I've successfully resolved the issue and submitted a PR for review today after some testing.

ecurrencyhodler commented 9 months ago

Can you submit the PR? I don't see it in our repo.

aliraza556 commented 9 months ago

@ecurrencyhodler, please give me some time. I will submit the PR shortly.

aliraza556 commented 9 months ago

@kevkevinpal Should it be clickable ? If no tribes attached ?

It should not be clickable and greyed out similar to what we do with the delete button

Hi @kevkevinpal @ecurrencyhodler Please check the demo If everything is correct, I will create a PR. If there is anything to add or modify, please provide me with your feedback.

ecurrencyhodler commented 9 months ago

That LGTM. Repost the video when you submit the PR.

aliraza556 commented 9 months ago

Hi @ecurrencyhodler Please review PR #1327.

aliraza556 commented 9 months ago

Hi @ecurrencyhodler Please review PR https://github.com/stakwork/sphinx-tribes/pull/1327.