stakwork / sphinx-tribes

Backend for sphinx tribes and bounties. The bounty platform pays out in bitcoin. Sign up with Sphinx Chat, complete a bounty, and earn bitcoin! Go to our website for available bounties.
https://community.sphinx.chat/bounties
33 stars 60 forks source link

Make bounty page go back to the home page #1362

Closed ecurrencyhodler closed 9 months ago

ecurrencyhodler commented 9 months ago

Describe the bug If I paste a bounty page (https://community.sphinx.chat/bounty/1181) into a brand new tab and "x" to close it, it takes me back to the google home page. Let's have it return the user to the homepage: https://community.sphinx.chat/bounties

https://github.com/stakwork/sphinx-tribes/assets/32662508/3e4bf33b-7320-4b30-a918-6523b0c9ac74

Expected behavior I should be returned to the bounty home page. This should ONLY affect going directly to a bounty page. All other times, closing the bounty page should return the user back to what they were looking at before. For example if I look at a bounty page from my profile, I should be returned to my profile not the bounty home page.

Desktop (please complete the following information):

Acceptance Criteria

ecurrencyhodler commented 9 months ago

You already have a couple bounties let's leave this open for other hunters.

MirzaHanan commented 9 months ago

Hi @ecurrencyhodler can you assign me?

KumarNayan commented 9 months ago

Can I take this up @ecurrencyhodler

Ekep-Obasi commented 9 months ago

@ecurrencyhodler, could I please work on this?

vishnu552 commented 9 months ago

Hi @ecurrencyhodler ,can i work on this issue?

ecurrencyhodler commented 9 months ago

@MirzaHanan are you on Sphinx chat? You can take this one as well as the bitcoin bounty with it.

MirzaHanan commented 9 months ago

Hi @ecurrencyhodler, I am currently not on Sphinx Chat.

ecurrencyhodler commented 9 months ago

Here are instructions in our FAQ to sign up with sphinx.

You can sign up as a new user with this connection code (Check your email).

Then sign in to our site and reply back with your sphinx name: https://community.sphinx.chat/bounties

BTW how did you hear about our project?

MirzaHanan commented 9 months ago

I was referred to this platform by @aliraza556.

ecurrencyhodler commented 9 months ago

Awesome let me know when you've created an account what your user name is.

MirzaHanan commented 9 months ago

Hi ecurrency, code is invalid [image: image.png]

On Tue, Jan 16, 2024 at 11:00 AM ecurrencyhodler @.***> wrote:

Here are instructions in our FAQ https://docs.google.com/document/d/16NQ4SM4ptP4Lz5JKERAagdNw3GFRVv9eshMZ_oU-MVw/edit?usp=sharing to sign up with sphinx.

You can sign up as a new user with this connection code:

connect::relay.swarm4.sphinx.chat::03bb3400b6fdfee72a8869c87f4de81210da5a8c9d1d7f7b7f166f22ba497cccfe

Then sign in to our site and reply back with your sphinx name: https://community.sphinx.chat/bounties

BTW how did you hear about our project?

— Reply to this email directly, view it on GitHub https://github.com/stakwork/sphinx-tribes/issues/1362#issuecomment-1893117771, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX3DZICAHNIHHG4DZ4NU2M3YOYJQTAVCNFSM6AAAAABB354DO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGEYTONZXGE . You are receiving this because you were mentioned.Message ID: @.***>

ecurrencyhodler commented 9 months ago

Did you download the app from the app store or test flight?

MirzaHanan commented 9 months ago

i download play store

On Tue, Jan 16, 2024 at 11:35 AM ecurrencyhodler @.***> wrote:

Did you download the app from the app store or test flight?

— Reply to this email directly, view it on GitHub https://github.com/stakwork/sphinx-tribes/issues/1362#issuecomment-1893148186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX3DZIBB77XC2ONQEOQSRM3YOYNTTAVCNFSM6AAAAABB354DO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGE2DQMJYGY . You are receiving this because you were mentioned.Message ID: @.***>

ecurrencyhodler commented 9 months ago

Oh okay that should be fine.

Try this one: connect::relay.swarm4.sphinx.chat::0217a4a1a1c9d027ae5d08074aea546ecd3738bcb187d272b82ce3ad47986a97ef

MirzaHanan commented 9 months ago

Oh okay that should be fine.

Try this one: connect::relay.swarm4.sphinx.chat::0217a4a1a1c9d027ae5d08074aea546ecd3738bcb187d272b82ce3ad47986a97ef

Hi @ecurrencyhodler, this code worked and my sphinx name is Mirza Hanan.

MirzaHanan commented 9 months ago

Thank Man!

ecurrencyhodler commented 9 months ago

okay great! I've assigned the bounty to you: https://community.sphinx.chat/bounty/1182

You may now start working on this issue. Just as a heads up, I am instituting a new rule that if I don't hear back in 7 days I will unassign the bounty and issue from you.

MirzaHanan commented 9 months ago

Hi @ecurrencyhodler,

Please take a look at my demo. If everything is in accordance with the task requirements, I will then create a PR.

ecurrencyhodler commented 9 months ago

Video looks great. Thanks for testing the edge cases as well. Create a pr and include the video as well!

MirzaHanan commented 9 months ago

Ok Thanks Man!

MirzaHanan commented 9 months ago

Hi @ecurrencyhodler, Do I need to add a unit test to resolve the issue? OR Just resolve the issue and then create a pull request and include a demo video in the PR description.

ecurrencyhodler commented 9 months ago

Hey Mirza! Yes that's correct. We want to implement test-driven development so include a test.

MirzaHanan commented 9 months ago

Absolutely, I completely agree with the approach! Implementing test-driven development will undoubtedly enhance our project's quality and reliability. I'll start by writing a comprehensive test for the new feature we're working on. Looking forward to seeing the positive impact this will have on our project!

MirzaHanan commented 9 months ago

Hi @ecurrencyhodler, Please review this PR #1428.

MirzaHanan commented 9 months ago

Hi @ecurrencyhodler @elraphty, Please check new PR in new repo and also check new demo

ecurrencyhodler commented 9 months ago

Tested and it works! GJ and paid.