Backend [Integration Test] tribes.go handlers GetAllTribes, GetTotalribes, & GetListedTribes - Githubissues

stakwork / sphinx-tribes

Backend for sphinx tribes and bounties. The bounty platform pays out in bitcoin. Sign up with Sphinx Chat, complete a bounty, and earn bitcoin! Go to our website for available bounties.

https://community.sphinx.chat/bounties

33 stars 60 forks source link

Backend [Integration Test] tribes.go handlers GetAllTribes, GetTotalribes, & GetListedTribes #1527

Closed elraphty closed 8 months ago

elraphty commented 8 months ago

Context

We are trying to increase the test coverage for our Golang backend.

File to to test

handlers/tribes.go

Design

Write tests for the tribe's handlers, the test should:

Should test that all tribes are listed
Should test that the total number of tribes is returned
Should test that tribes with the passed tags are returned when the GetListTribes handler receives a tag query
Should test that the GetListTribes handler returns all tribes if no tag is passed.

Tribes Handlers To Test

GetAllTribes
GetTotalribes
GetListedTribes

Add tests to tribes_test.go

Acceptance Criteria

[ ] I have rebased and tested locally before submitting my PR
[ ] I can submit a PR within 2 days of taking the bounty

References

Watch this Jest Youtube playlist if you are new to testing
Here is an example unit test
Here is an example component test

Here is an example backend test

hkarani commented 8 months ago

Hey @ecurrencyhodler can you assign this to me.

ecurrencyhodler commented 8 months ago

Let's get a PR in 2 days.

hkarani commented 8 months ago

@ecurrencyhodler

Can I some more time with this?

I'm having an issue with clashing function signatures.

ecurrencyhodler commented 8 months ago

Thanks for the update. Can you submit something by tomorrow?

hkarani commented 8 months ago

Done!

ecurrencyhodler commented 8 months ago

paid 200k sats! https://community.sphinx.chat/bounty/1526

hkarani commented 8 months ago

Giving it the best shot.

On Tue, Feb 20, 2024 at 10:30 AM ecurrencyhodler @.***> wrote:

Let's get a PR in 2 days.

— Reply to this email directly, view it on GitHub https://github.com/stakwork/sphinx-tribes/issues/1527#issuecomment-1953625641, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN7TITIN5AAXNW6JLRFKGB3YURGKRAVCNFSM6AAAAABDPVXEJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGYZDKNRUGE . You are receiving this because you were assigned.Message ID: @.***>

hkarani commented 8 months ago

Got em! Thanks @ecurrencyhodler.

😃

On Mon, Feb 26, 2024 at 7:08 PM Hezron Karani @.***> wrote:

Giving it the best shot.

On Tue, Feb 20, 2024 at 10:30 AM ecurrencyhodler @.***> wrote:

Let's get a PR in 2 days.

— Reply to this email directly, view it on GitHub https://github.com/stakwork/sphinx-tribes/issues/1527#issuecomment-1953625641, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN7TITIN5AAXNW6JLRFKGB3YURGKRAVCNFSM6AAAAABDPVXEJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGYZDKNRUGE . You are receiving this because you were assigned.Message ID: @.***>