stakwork / sphinx-win-linux-desktop

MIT License
49 stars 13 forks source link

Error while running `npm install` #136

Open CypherPoet opened 3 years ago

CypherPoet commented 3 years ago

When running npm install using npm 7.5.2 and node v14.16.0, I get the following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: sphinx@0.1.0
npm ERR! Found: react@16.13.1
npm ERR! node_modules/react
npm ERR!   react@"16.13.1" from the root project
npm ERR!   peer react@"^15.0.0 || ^16.0.0" from @cleandersonlobo/react-mic@1.2.0
npm ERR!   node_modules/@cleandersonlobo/react-mic
npm ERR!     @cleandersonlobo/react-mic@"^1.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.14.0" from react-dom@16.14.0
npm ERR! node_modules/react-dom
npm ERR!   react-dom@"^16.9.0" from the root project
npm ERR!   peer react-dom@"^15.0.0 || ^16.0.0" from @cleandersonlobo/react-mic@1.2.0
npm ERR!   node_modules/@cleandersonlobo/react-mic
npm ERR!     @cleandersonlobo/react-mic@"^1.2.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!

It looks like running npm install --legacy-peer-deps does, indeed, get around this, but I’m curious about the best path forward for the project here. We could try to upgrade react to ^16.4.1, or, if we’re not ready to do that, update the README installation instructions to include the extra --legacy-peer-deps argument.

Related:

Evanfeenstra commented 3 years ago

I guess upgrading to React 16.4.1 is the best path forward, feel free to give it a try :)