search

stakx-io / stakx

An opinionated, powerful, and simple static website generator built in PHP
https://stakx.io/
MIT License
14 stars 3 forks source link

Update example theme #108

Closed PeterMedina closed 4 years ago

PeterMedina commented 4 years ago

Summary

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed issues N/A

Description

Integrates Bootstrap 4 styles to the Stakx example theme; does not change or update existing example theme content.

Check List

allejo commented 4 years ago

What's the reasoning behind importing all of the Sass files for Bootstrap in the theme? Why not just use the compiled CSS like we were doing for Bootstrap 3?

I'm really hesitant on introducing all of Bootstrap core into this example site.

PeterMedina commented 4 years ago

Including full Bootstrap 4 was done to demonstrate full customization potential of the theme, if need be.

The customization currently in use only affects typography, however. Mainly font size, color, weight, and family.

Are you open to a PurgeCSS pass being run on the generate site in order to create a significantly minimized Bootstrap file (externally — not suggesting it be included with Stakx as a dependency), then a separate custom.scss file being packaged as a demo of using SCSS to compliment the compiled CSS file?

allejo commented 4 years ago

I rebased on top of develop after the calendar dates updates got merged in. I also changed a few things around on how stylesheets are included/built mainly since the example site is intended to show a lot of stakx's features.

Are you open to a PurgeCSS pass being run on the generate site in order to create a significantly minimized Bootstrap file (externally — not suggesting it be included with Stakx as a dependency), then a separate custom.scss file being packaged as a demo of using SCSS to compliment the compiled CSS file?

Something like PurgeCSS should be run against the compiled files in _site/. A theme shouldn't contain anything like that since a theme is intended to be used everyone so removing CSS classes would limit the theme's uses.