search

stakx-io / stakx

An opinionated, powerful, and simple static website generator built in PHP
https://stakx.io/
MIT License
15 stars 3 forks source link

Warning thrown in debug when page has many children in the site menu #37

Closed allejo closed 7 years ago

allejo commented 7 years ago

System Information

PHP Version:

7.0.15

stakx Version:

master

Operating System

macOS 10.11.6

Expected behavior

Not to throw a warning

Actual behavior

Throws the following warning; see http://stackoverflow.com/a/19749730

Notice: Indirect modification of overloaded element of allejo\stakx\Object\PageView has no effect in /path/to/stakx/src/Manager/PageManager.php on line 518

Call Stack:
    0.0027     356896   1. {main}() /path/to/stakx/bin/stakx:0
    0.0442    1440528   2. Symfony\Component\Console\Application->run() /path/to/stakx/bin/stakx:13
    0.0576    1687912   3. allejo\stakx\Core\Application->doRun() /path/to/stakx/vendor/symfony/console/Application.php:120
    0.0578    1688256   4. Symfony\Component\Console\Application->doRun() /path/to/stakx/src/Core/Application.php:17
    0.0580    1688256   5. Symfony\Component\Console\Application->doRunCommand() /path/to/stakx/vendor/symfony/console/Application.php:189
    0.0580    1688256   6. Symfony\Component\Console\Command\Command->run() /path/to/stakx/vendor/symfony/console/Application.php:826
    0.0583    1756728   7. allejo\stakx\Command\WatchCommand->execute() /path/to/stakx/vendor/symfony/console/Command/Command.php:262
    0.0677    2286768   8. allejo\stakx\Object\Website->watch() /path/to/stakx/src/Command/WatchCommand.php:28
    0.0677    2286768   9. allejo\stakx\Object\Website->build() /path/to/stakx/src/Object/Website.php:189
    0.1219    2696272  10. allejo\stakx\Manager\PageManager->parsePageViews() /path/to/stakx/src/Object/Website.php:138
    0.1220    2697136  11. allejo\stakx\Manager\TrackingManager->scanTrackableItems() /path/to/stakx/src/Manager/PageManager.php:172
    0.1455    2889392  12. allejo\stakx\Manager\PageManager->handleTrackableItem() /path/to/stakx/src/Manager/TrackingManager.php:278
    0.1457    2893048  13. allejo\stakx\Manager\PageManager->addToSiteMenu() /path/to/stakx/src/Manager/PageManager.php:310

Steps to reproduce behavior

This seems to occur when there are multiple children to a parent page; for example:

allejo commented 7 years ago

My understanding of this bug is that it was caused due to the defined magic methods and they've been removed since #36 so this shouldn't be an issue anymore.