search

stal111 / Forbidden-Arcanus

Forbidden & Arcanus Mod Github
https://minecraft.curseforge.com/projects/forbidden-arcanus
111 stars 45 forks source link

GTCEU & Eternal Stella Compatibility Feature Request #387

Open Ghostipedia opened 5 months ago

Ghostipedia commented 5 months ago

Is your feature request related to a problem? Please describe. YES GregTech:Modern has Recently released a tool refactor which Makes the eternal stella incompatible with most of their tools, and It would be amazing to see Stella support added for their toolsets

Describe the solution you'd like Presently the Eternal Stella only applies visually to tools (Naming them Eternal, Giving a nice border, etc) But doesn't actually restore/keep the durability Maximum

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. Worst Case, when adding an eternal Stella to a GT Tool, it sets the unbreakable flag, as they do that with tools made of "Neutronium," which would also resolve this issue.

Additional context Add any other context or screenshots about the feature request here. Some screens of NBT between a Compressed Iron Chestplate (Which works with the Stella) and a Steel hammer (Which does not) image

mikerooni commented 5 months ago

Imo, setting the unbreakable tag automatically when applying Eternal Stella would be best indeed.
Doing so wouldn't require any additional compatibility changes for each individual mod, as that is a vanilla feature already and can just be hooked into.

For GTCEu Modern specifically, we can't use Minecraft's regular durability system unfortunately, as we need two independent durability values used for separate purposes. We do, however, respect the unbreakable tag.