stal111 / Forbidden-Arcanus

Forbidden & Arcanus Mod Github
https://minecraft.curseforge.com/projects/forbidden-arcanus
129 stars 49 forks source link

Recipe Bug and Partial Data Generation Fix #418

Closed HeroBrianMack closed 1 month ago

HeroBrianMack commented 4 months ago

This pull request will move non-generated data out of the generated folder and into its normal location. It refreshes the recipes (fixes the recipes in issue #410), resolves the "[Render thread/WARN]: Unknown recipe category" error, enables/fixes the ModBiomeModifiers and ModLootTableProvider classes. Issue #360 Resolves the EnderIO double broken spawner drop by making a different LootTableModifier for that specific LootTable.

Most Recent Fix: Issue #313 Buckets not saving age, names, and health of non-bucketable mobs (basically mobs that aren't like an axolotl and able to be put in a bucket in vanilla).

If there's anything you don't like in my changes please let me know!

stal111 commented 1 month ago

Thank you for your effort. However, it would have been helpful if you had contacted me before creating such an enormous pull request. The whole datagen of the mod was horribly broken in 1.20.x which is why many of these recipe errors exist. Running the datagen task removes many of the mods recipes and such (see the large set of deleted files in your pr) and thus this is not suited for release.