search

stale-reactjs-org-translations / ro.reactjs.org

(Work in progress) React documentation website in Romanian
roreactjsorg.fbopensource.vercel.app
Creative Commons Attribution 4.0 International
17 stars 17 forks source link

RO translations for Home Page, Header, Footer and Docs and Community navs #94

Open gabimoncha opened 5 years ago

gabimoncha commented 5 years ago

This PR adds Romanian translations to Home Page #7 , Header, Footer and Docs and Community Navs

netlify[bot] commented 5 years ago

Deploy preview for ro-reactjs failed.

Built with commit 44a7eb886740463d9944105597c39b3e0fc217c9

https://app.netlify.com/sites/ro-reactjs/deploys/5e8ac88a7373a40007e9aba3

tesseralis commented 5 years ago

@nikiciv this might be ready for a re-review?

gabimoncha commented 5 years ago

@tesseralis @nikiciv - It would be great if we can merge this as I am waiting to continue work with the others.

tesseralis commented 5 years ago

@gabrielmoncea you can start working on another page while this is in review!

micnic commented 5 years ago

Hi, I would like to add some general rules to improve the translation to Romanian of the text in this commit (but these rules, I guess, could be used in the whole repo). First of all, I'm also a speaker of Russian and French, which are accepted already as finished translations, and based on my past experience in translating to Romanian, I recommend the following:

  1. Do not capitalize all the words in titles (It is common for English, not for Romanian), examples: Resurse Externe, Bănci de lucru pentru Componente, Trusă pentru Început. As I see some titles are capitalized, some - not, there should be a consistency.

  2. Do not translate all the notions to Romanian, in French translation Hooks are called Hooks, in Russian - Хуки (spelled as Hooky, to match "hook" + Russian plural termination), "Cârlig" / "Cârlige" does not sound that good, and can add some misunderstanding of those who will use the name based on Hook and those who will use it based on "Cârlig", in my opinion for this case "Hook" / "Hook-uri" will fit better.

gabimoncha commented 5 years ago

@micnic thanks a lot for the review. We were thinking on making a list of terminology that we should keep as it is in English. It would be great if you could jump in :D

@tesseralis I will continue on this one to implement the review suggestions

micnic commented 5 years ago

@gabrielmoncea will find some time, as I teach React, the documentation in Romanian would help students to understand it better in their native language. For now will follow the process of accepting of this PR.

RaulTsc commented 4 years ago

@gabrielmoncea minor comment la sectiunea 'Unelte', s-ar putea sa nu mai existe in master. Otherwise LGTM