search

stale-reactjs-org-translations / ro.reactjs.org

(Work in progress) React documentation website in Romanian
roreactjsorg.fbopensource.vercel.app
Creative Commons Attribution 4.0 International
17 stars 17 forks source link

Update forms.md Issue #17 #95

Open ael-mas opened 5 years ago

ael-mas commented 5 years ago
netlify[bot] commented 5 years ago

Deploy preview for ro-reactjs ready!

Built with commit 09e06c02eb82c429c4b9507ec418117fdbfd5e70

https://deploy-preview-95--ro-reactjs.netlify.com

tesseralis commented 5 years ago

@ael-mas could you respond to the comments @gabrielmoncea gave?

ael-mas commented 5 years ago

Hey, sorry I haven't been responding. I will fix everything @gabrielmoncea mentioned as soon as possible, I've just been a little busy with school.

gabimoncha commented 5 years ago

@ael-mas try to also follow this review that myself got on the other PR :)

ael-mas commented 5 years ago

I've made the changes in my forked repository. Is there a way to update my pull request with the changed forms.md file or do I have to submit another pull request?

ael-mas commented 5 years ago

@gabrielmoncea let me know if there's anything else I should change

tesseralis commented 5 years ago

@ael-mas you should just be able to do git push to update those changes. @gabrielmoncea could you re-review?

gabimoncha commented 5 years ago

@ael-mas @tesseralis I will review the new changes as soon as I am free. It should happen sometime this week or over the weekend

gabimoncha commented 5 years ago

@ael-mas @tesseralis I'm sorry but the changes from my review were not applied completely

RaulTsc commented 4 years ago

@ael-mas @gabrielmoncea FYI am rezolvat conflictele dar s-a intamplat ceva dubios cu change-urile. O sa fac checkout local si o sa updatez PR-ul cu comment-urile din nou.