Readme p5.xr min version update

stalgiag / p5.xr

a library that helps turn p5.js sketches into immersive experiences using WebXR

GNU Lesser General Public License v2.1

117 stars 25 forks source link

Readme p5.xr min version update #214

Closed TiborUdvari closed 6 months ago

TiborUdvari commented 7 months ago

WebGL2 support and p5.instance.webglVersion check was introduced in version 1.7.0 https://github.com/processing/p5.js/releases/tag/v1.7.0. Getting webgl context will fail if in older versions. Example mentioned in #203 currently fails because of this.

p5 editor examples should be updated if possible.

TiborUdvari commented 7 months ago

I don't think there is a good way to update p5 web editor examples, should I just update the links with working examples on my p5 web editor account when I fix something? https://editor.p5js.org/TiborUdvari/sketches/fgA0L9jQ6

stalgiag commented 6 months ago

Thanks for this! Yeah I think it makes sense to update the editor sketch links to whoever is hosting the most recent example. The web editor offers a lot of advantages for first time users (immediately duplicate example, try in browser without running local server) but it does make editing hard. Another option is that we could make a p5.xr user and have a secret stored in the repo that has the login info.