search

stalgiag / p5.xr

a library that helps turn p5.js sketches into immersive experiences using WebXR
GNU Lesser General Public License v2.1
117 stars 25 forks source link

IntersectsPlane() #50

Closed vedhant closed 5 years ago

vedhant commented 5 years ago

implements #46 This PR depends on #49

vedhant commented 5 years ago

The manual example i added here is a simple example of dragging a box in a fixed plane.

vedhant commented 5 years ago

@stalgiag I have rebased and pushed. You can merge it when you are done reviewing it.

stalgiag commented 5 years ago

I am unable to get this working but I am also unable to get the manual test for intersects box to work anymore. intersectsBox() never returns true in either. If this is only on my phone then I am happy to investigate more. Interact is as expected on your end currently?

vedhant commented 5 years ago

I have fixed it. The problem was in the intersectsBox() arguments. I had forgot to change it in the examples when I had modified the parameters for it.

vedhant commented 5 years ago

Fixes #53 .