search

staltz / easy-ssb-pub

An easy-to-host server that runs an SSB "Pub"
GNU Affero General Public License v3.0
209 stars 35 forks source link

Pin typescript version to avoid breaking changes #23

Closed retrohacker closed 6 years ago

retrohacker commented 6 years ago

Issues

Closes #18

TypeScript seems to ship breaking changes upstream as patch version bumps. Currently, if you git clone this repo and attempt to run the pub, you get:

> easy-ssb-pub@4.0.0 start /usr/src/app
> tsc && node dist/index --host $HOST --no-discovery

src/discovery.ts(113,3): error TS2322: Type 'Observable<{}>' is not assignable to type 'Observable<Response>'.
    Type '{}' is not assignable to type 'Response'.
        Property 'text' is missing in type '{}'.

Changes

This PR pins to a specific, known working, version of TypeScript. Opting into future releases requires an explicit upgrade.

staltz commented 6 years ago

Thanks!