Closed cristinecula closed 10 years ago
On second thought, I have noticed that the reduce method already exists and it's basically the same thing. I'm not sure if they should both be present, it might create confusion :)
Hi @cristinecula I appreciate your issue and PR! And true, I don't know what's the difference between reduce
and aggregate
, and reduce is in rxmarbles already.
https://github.com/Reactive-Extensions/RxJS/blob/master/src/core/linq/observable/aggregate.js
https://github.com/Reactive-Extensions/RxJS/blob/master/src/core/linq/observable/reduce.js
Currently I'm focusing on building features that are necessary for showing more operators. For instance, some operators depend a lot when the onCompleted happens, so I'm working on rendering the onCompleted marker. Also other operators are error-related so first need to render errors. Then there are metastream operators, etc.
Thank you @staltz for the reply. I will close this pull request for now and will continue following your awesome project.
First of all let me say that I love rxmarbles! It has helped me alot in understanding how rxjs observables work.
I think that aggregate is not simply a clone of scan, since it emits only the final value of the aggregation. I found this extremely useful after doing a groupBy to create another stream where the groups are reduced to single values with accumulated properties:
Therefore I think this transformation deserves it's own place in the examples.