search

staltz / ssb-room

A server to find and connect to other SSB peers – a meeting place. AGPL-3.0
GNU Affero General Public License v3.0
109 stars 17 forks source link

Splitting out the tunnel directory into a separate module #14

Open arj03 opened 3 years ago

arj03 commented 3 years ago

Trying to add this as a module to ssb-browser I see that a lot of stuff is pulled in (like ssb-master). I was wondering if it would make sense to split out the actual implementation into maybe two modules? ssb-room-server and ssb-room-client?

staltz commented 3 years ago

ssb-room-server and ssb-room-client?

Agree. But just to clarify, you're talking specifically about ./tunnel/server.js and ./tunnel/client.js, right? This module ssb-room requires ssb-master because it has all the other things for running the server. In other words, this module is not really a simple SSB plugin, it is bundling a bunch of things. And it should, as you said, be implemented more granularly.

arj03 commented 3 years ago

Yes, and probably also utils.js into its own module. Still learning here :-)