Closed LeoniePhiline closed 1 year ago
Please check the latest commit, now Error implements std::error::Error.
Thanks so much!
Are you planning a minor / patch version release any time soon?
Just published version 0.3.2
on crates.io!
Thank you! :) Also thank you for open sourcing your work! I wish you the best of luck for your company!
Hello!
I've been using
thiserror
and stumbled upon this when trying to integratemail_send
:mail_send::Error
(and alsomail_auth::Error
) do not implement thestd::error::Error
trait. That's why they cannot be simply integrated into other error-frameworks which all build on the std lib'sError
trait.mail_send
andmail_auth
could also opt into using thethiserror
crate.thiserror::Error
is entirely transparent to the library user, and takes some boilerplate away from you.Here's how this could look like: https://github.com/jolimail/mrml-core/pull/38/files#diff-c08afca406e15cd665ef6c443014a8472bb79435231a21463239333886aed304
A pure
std::error::Error
implementation, without#[derive(thiserror::Error)]
might look like this: https://docs.rs/askama_shared/0.12.2/src/askama_shared/error.rs.html#43-54