Webpack encore correctly support

stamat / youtube-background

ESM / jQuery plugin for creating video backgrounds from YouTube, Vimeo or video file links.

https://stamat.github.io/youtube-background/

MIT License

176 stars 54 forks source link

Webpack encore correctly support #22

Closed Quetzalfir closed 3 years ago

Quetzalfir commented 3 years ago

It has some little fixes and improvements.

Added a callback in order to let the user know when the video is (event->data ==== 1)started o (event->data === 0)finished.

Parameter passed now works, before the parameters were never assigned, so defaults was always setted.

Webpack Encore correctly support, now jQuery is detected correctly, and the function constructor is exported, in order to be imported in a proper way, as a module.

Quetzalfir commented 3 years ago

@stamat : Feb 14, 13:48

stamat commented 3 years ago

Hey! 👋 Thanks so much for the contribution! I'll take a detailed look this week and I'll merge your suggestion! So sorry for the late reply, I'm quite busy these days! ❤️

stamat commented 3 years ago

@Quetzalfir thanks for contributing ❤️ sorry I couldn't merge this sooner! 🙏