search

stamatak / ExaML

Exascale Maximum Likelihood (ExaML) code for phylogenetic inference using MPI
49 stars 25 forks source link

Memory Leaks #7

Closed daniel-j-h closed 9 years ago

daniel-j-h commented 9 years ago

sitesPerProc: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/partitionAssignment.c#L476

numsPerProc: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/partitionAssignment.c#L479

destinationUnordered: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/communication.c#L137

Found by Clang's Static Analyzer (LLVM 3.5).

cmayer commented 9 years ago

As far as I know, avoiding "free" statements where ever possible is part of the efficiency strategy of ExaML. Not kidding. Freeing memory is much more efficient, if it is done when exiting the program than while running. This strategy can be used for memory that is needed during the whole run or for cases in which the leak is negligible and not "excessively" cumulating. Are there any indications of problems caused by these leaks?

Am 30.10.2014 um 22:24 schrieb Daniel J. H.:

sitesPerProc: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/partitionAssignment.c#L476

numsPerProc: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/partitionAssignment.c#L479

destinationUnordered: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/communication.c#L137

Found by Clang's Static Analyzer (LLVM 3.5).

— Reply to this email directly or view it on GitHub.

stamatak commented 9 years ago

Thanks for the statement below, what cmayer says is correct, i.e., those "leaks" should not cause a problem, I am not aware of any leaks within the code,

Alexis

On 30.10.2014 23:52, cmayer wrote:

As far as I know, avoiding "free" statements where ever possible is part of the efficiency strategy of ExaML. Not kidding. Freeing memory is much more efficient, if it is done when exiting the program than while running. This strategy can be used for memory that is needed during the whole run or for cases in which the leak is negligible and not "excessively" cumulating. Are there any indications of problems caused by these leaks?

Am 30.10.2014 um 22:24 schrieb Daniel J. H.:

sitesPerProc: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/partitionAssignment.c#L476

numsPerProc: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/partitionAssignment.c#L479

destinationUnordered: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/communication.c#L137

Found by Clang's Static Analyzer (LLVM 3.5).

— Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub: https://github.com/stamatak/ExaML/issues/7#issuecomment-61183356

Alexandros (Alexis) Stamatakis

Research Group Leader, Heidelberg Institute for Theoretical Studies Full Professor, Dept. of Informatics, Karlsruhe Institute of Technology Adjunct Professor, Dept. of Ecology and Evolutionary Biology, University of Arizona at Tucson

www.exelixis-lab.org

stamatak commented 9 years ago

thanks for this, I just had a closer look and fixed the two issues,

alexis

On 30.10.2014 22:24, Daniel J. H. wrote:

sitesPerProc: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/partitionAssignment.c#L476

numsPerProc: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/partitionAssignment.c#L479

destinationUnordered: https://github.com/stamatak/ExaML/blob/651bd8ea4afaf037bbf9080e91114e2ebe6579c5/examl/communication.c#L137

Found by Clang's Static Analyzer (LLVM 3.5).

Reply to this email directly or view it on GitHub: https://github.com/stamatak/ExaML/issues/7

Alexandros (Alexis) Stamatakis

Research Group Leader, Heidelberg Institute for Theoretical Studies Full Professor, Dept. of Informatics, Karlsruhe Institute of Technology Adjunct Professor, Dept. of Ecology and Evolutionary Biology, University of Arizona at Tucson

www.exelixis-lab.org