stamatak / standard-RAxML

www.exelixis-lab.org
325 stars 192 forks source link

fix parenthesis mismatch bug leads to potential unexpected behavior #31

Closed hrabe closed 8 years ago

hrabe commented 8 years ago

Reverted the code cleanup/reformatting due to merge conflicts and only fixed both places.

Finding this issue was not easy because of the bad code formatting. The Microsoft compiler throw errors either about not initialized variables or not reachable code.

Unfortunately the gcc and clang based build have had no problems with this malformed parenthesis but I’m unsure if they just optimize away the non reachable code.

will close #29

Remark: most file need a white-space tidy up and correct re-formatting to be easier to read (especially in stacked switch/case blocks with stack frames).