search

stamblerre / gocode

An autocompletion daemon for the Go programming language
MIT License
394 stars 28 forks source link

Upgrade to new packages interface #5

Closed egonelbre closed 6 years ago

egonelbre commented 6 years ago

Fixes #4

yfwz100 commented 6 years ago

Seems to work fine.

zeybek commented 6 years ago

Hope it will be merged soon !

joaojeronimo commented 6 years ago

This is creating a new variable srcdata that is not used, while src is still being initialised as an empty interface right on the next line. Would this be better ?

egonelbre commented 6 years ago

@joaojeronimo changing it such will change the behavior of the code. It might be still correct, but I don't know the code that well to say for certain.

Scapal commented 6 years ago

Please merge, Microsoft/vscode-go is unusable and it is probably the largest usage of this library.

No change is breaking most projects depending on your lib.

stamblerre commented 6 years ago

Sorry about not merging this earlier--somehow didn't get a notification for this. Should be fixed now.