search

stamen / chartographer

https://stamen.github.io/chartographer/
MIT License
19 stars 4 forks source link

Download SVG (for fill and line) #22

Closed aparlato closed 2 years ago

aparlato commented 2 years ago

Closes #11

Adds a download button for the fill and line charts to export as a single SVG for each.

This currently doesn't handle the typography chart which we will explore Figma integrations with as part of https://github.com/stamen/mapbox-gl-style-design-system/issues/19 since it uses Mapbox GLJS rather than SVG to display in the tool.

aparlato commented 2 years ago

@ebrelsford thanks for the feedback! I updated per your comments and left a couple comments inline as well. Mostly I'm not sure what's going on with the package-lock. I tried resetting to main and reinstalling my added package to make sure this wasn't a mistake and that appears to just be what it's generating. Do you have any thoughts on why it appears to have removed so much?

ebrelsford commented 2 years ago

@aparlato I'm not sure which version of npm you're using but maybe it would help if we decided on one to use. I'm on v7.24.0 and here is the output I get when I npm install on this branch:

image

So it seems like you may be on an older version that doesn't include that metadata in the package-lock.json, but when I npm install it adds it...right?

Which version should we use? I don't have too much of an opinion but it does seem the LTS would put us at node v16.14.0 and npm v8.3.1, maybe we just go with that if you're open?

aparlato commented 2 years ago

@ebrelsford thanks! I was using node 12 so you are right, that turned out to be the issue.

I don't have too much of an opinion but it does seem the LTS would put us at node v16.14.0 and npm v8.3.1, maybe we just go with that if you're open?

This sounds good! I added engines to our package.json to specify node: >=16