stamen / chartographer

https://stamen.github.io/chartographer/
MIT License
19 stars 4 forks source link

step handling #32

Closed aparlato closed 2 years ago

aparlato commented 2 years ago

This PR fixes a bug noticed by @kelsey-taylor where a combination of color and opacity expressions in which one used a step expression wasn't handled appropriately. We weren't handling step expressions at all which should have resulted in a black line, but the code was written in a way that allowed a step expression to get somewhere that it shouldn't causing the app to crash rather than just show an inaccurate visual.

For now, this PR adds handling for zoom step expressions only. There's a followup issue to be made for handling scale expressions (step and interpolate) for data expressions in our expandLayers logic. In the meantime, this will warn on those unhandled expressions.