search

stamen / chartographer

https://stamen.github.io/chartographer/
MIT License
19 stars 4 forks source link

SVG export not working for some layers #35

Closed kelsey-taylor closed 2 years ago

kelsey-taylor commented 2 years ago

Describe the issue

I tried exporting the fill chart for the OS Zoomstack style and am seeing a lot of black where there should be other colors:

Screen Shot 2022-07-01 at 1 58 31 PM Screen Shot 2022-07-01 at 1 58 43 PM

I'm not sure why this is since the values for these colors don't seem particularly different from any others in this stylesheet 🤷‍♀️

os_openzoomstack-_outdoor.json.zip

kelsey-taylor commented 2 years ago

i just took a peek at the actual SVG file itself and it renders fine outside of Figma 🤔 8jj0kx5wm-fill-chart

aparlato commented 2 years ago

@kelsey-taylor I believe I ran into this a while ago when looking into making this a plugin, and if I remember correctly, Figma won't render hsl colors correctly and just shows black. We might have to convert our SVG output to rgb or hex for use in Figma.

I know we've been preferring hsl colorspace in stylesheets for some clients, but since the output SVG from this tool is just for visual purposes, it seems like it should be fine to convert. If that sounds alright I can go ahead and make those changes.

kelsey-taylor commented 2 years ago

yeah that sounds fine to me @aparlato! i also wonder if hsla would work instead of just hsl 🤔 either way, i think changing the output is fine!