stamen / chartographer

https://stamen.github.io/chartographer/
MIT License
19 stars 4 forks source link

Typography chart not rendering for Mapbox style #57

Closed kelsey-taylor closed 1 year ago

kelsey-taylor commented 1 year ago

Describe the issue

I opened a style designed in Mapbox Studio in chartographer and saw some unexpected results in the typography tab:

Using Mapbox GL — nothing renders Screenshot 2023-03-14 at 1 57 52 PM

Using Maplibre GL — only halo color renders Screenshot 2023-03-14 at 1 57 44 PM

I tried making the style public and reuploading, but there was no change. I tried uploading a default Mapbox style (Monochrome) and had the same issue.

Additional context

There are a lot of error messages — would probably be easier for whoever takes this task on to try it out themselves than for me to go screenshot them all, although it looks like an access token is the main first issue.

Screenshot 2023-03-20 at 11 54 21 AM
ebrelsford commented 1 year ago

Oh yes this is because we do not include an access token for Mapbox.

We should probably prompt the user for an access token since the style you're using might include references to sprites/glyphs/tilesets only your account has access to.

kelsey-taylor commented 1 year ago

Makes sense to me!