search

stamen / mapbox-gl-style-diff

Other
2 stars 1 forks source link

Refactor code #21

Open aparlato opened 1 year ago

aparlato commented 1 year ago

Closes https://github.com/stamen/mapbox-gl-style-diff/issues/19

This PR removes the old code which was pulled from the style spec and updated as needed with our own diffing code.

This slightly changes the output, so this would be a breaking change, but we could adjust back to the output we had before if that's more desirable. I think we could probably be a little more thoughtful about the final output here, but I updated the README to reflect the current state (mostly I wonder if we should remove before values or alternatively use before and after for all types of changes including removals and additions (which would use null for one of these).

@ebrelsford I'm curious if you think this is the right approach. Alternatively, I can quickly put together a branch where we just edit the output of the diff function in the style spec (rather than copypasta) to see if that feels better to maintain.

aparlato commented 1 year ago

Leaving a note here since I've let this sit a bit. Just want to come back and confirm there's nothing to handle in the TODO comments here before merging. I think some of it has to do with consistifying structure of the output more, which we might want to handle just once here in a major version update since this makes some changes already.