search

stamen / mapbox-gl-style-diff

Other
2 stars 1 forks source link

Tests #6

Closed aparlato closed 1 year ago

aparlato commented 2 years ago

Per this comment, I think this repo would benefit from unit tests. Since the diffing is intended as a QA step, we want to make sure a break in the code doesn't result in not showing important differences to the user.

@peterqliu what do you think of breaking down diff.js into different files (or at least different exported functions) (eg diffLayerPropertyChanges) and testing each individually with test cases that have the known changes we want to diff for?

I suggest using Jest over in https://github.com/stamen/amazon-MapStyleSandbox/issues/320 since I'm familiar with it, but open to whatever.

mulloverit commented 1 year ago

Stale! Will open a new ticket if/when needed.