stamen / maperture

https://stamen.github.io/maperture/
MIT License
39 stars 12 forks source link

Deal with Maplibre/Mapbox logo and other CSS overlapping #150

Closed ebrelsford closed 1 year ago

ebrelsford commented 1 year ago

As mentioned in #148, it's very confusing that the Maplibre logo appears even when you're using only Mapbox GL for your maps:

image

As I see it, this is happening because we bundle all of the CSS together and the Maplibre CSS is coming after the Mapbox CSS and overriding it.

We should:

kelsey-taylor commented 1 year ago

I've been thinking about this a lot in conjunction with #147 and #146 - I think removing the watermark altogether is the cleanest solution. You can't see it for all maps at once in swipe mode anyway, so I'm not sure it's providing much value at the moment. Will follow up in the other tickets about what solutions we can try to show the renderer in the UI instead

ebrelsford commented 1 year ago

Agreed, leaning that way too.

aparlato commented 1 year ago

I think removing the watermark altogether is the cleanest solution

Just posting how to do this here if helpful since I just did it elsewhere in a private repo. Just need to add this into the CSS for Map.svelte

/* Remove Mapbox attribution */
  :global(.mapboxgl-control-container) {
    display: none;
  }