search

stamen / modestmaps-js

Modest Maps javascript port
http://modestmaps.com
566 stars 152 forks source link

Layers-merge needs a .remove() message for queue clearing #70

Closed tmcw closed 12 years ago

tmcw commented 12 years ago

This was possible in the old work with referring to the one requestManager. We need something like an abstract remove method in the layer interface.

tmcw commented 12 years ago

Is this fixed in 1a0f41be74129567d29496cd38278c2338f348a5 ?

RandomEtc commented 12 years ago

I think so - layers got a destroy method which should be doing everything that was previously happening in Map.

If any objects are lingering then nothing short of browser testing will confirm/diagnose the issue, but let's wait for bug reports on that front since the architecture is reasonably sound.

tmcw commented 12 years ago

As far as I can see, there aren't any leaks sprouting from that, though Drip for IE is kind of overenthusiastic about reporting leaks everywhere. Closing for now.