stamen / terrain-classic

World-wide CartoCSS port of Stamen's classic terrain style
ISC License
144 stars 35 forks source link

water stroke is too thick at low zooms #13

Closed almccon closed 8 years ago

almccon commented 9 years ago

screen shot 2015-08-24 at 3 16 51 pm

Probably not necessary at low zooms. I recall that we depend on water outlines at high zooms, but I don't remember exactly why.

clhenrick commented 8 years ago

@almccon could you clarify this?

almccon commented 8 years ago

The water outlines are the same color as the water, so they're hard to spot, but at this zoom they are so fat that they spill onto the land. Denmark, for example, looks almost totally flooded.

clhenrick commented 8 years ago

Ah, okay that should be an easy fix (fingers crossed) thanks for clarifying.

clhenrick commented 8 years ago

@almccon seems like the culprit could be here: https://github.com/stamen/terrain-classic/blob/master/map.mss#L84-L92

However I'm not able to replicate this issue. When i change the color of the stroke it seems like it's already fairly thin. I do think the coastline generalization should change though. For example we should probably use the ne_50m_ocean at lower zooms for the coastline rather than the ne_10m_ocean which looks a little too detailed.

this is zoom level 4: screen shot 2015-09-01 at 4 32 16 pm

almccon commented 8 years ago

Yes, maybe it is thin, but even with those thin lines, they still wash out the land when they're the same color as water. Check out how wet Finland looks at that zoom: screen shot 2015-09-01 at 4 40 05 pm

But it's true that the problem isn't that bad at zoom 4. Zoom 3 is worse. Maybe we need to remove the lines entirely at zoom 0 through 4. Shouldn't have any unexpected consequences, I hope.

clhenrick commented 8 years ago

@almccon I feel that leaving out the stroke for water polygons at low zooms would be fine.

Alternatively we could play with using the ne_50m_ocean layer which has a more generalized coastline and/or making the coastline a darker stroke.

clhenrick commented 8 years ago

@almccon changing the water line stroke to 0, map background color to water for low zooms and using the ne_50m_ocean layer for the coastline seems to resolve this:

screen shot 2015-09-02 at 3 40 34 pm

almccon commented 8 years ago

Works for me. :ocean: