stamen / terrain-classic

World-wide CartoCSS port of Stamen's classic terrain style
ISC License
144 stars 35 forks source link

Labels are being lost in areas with lots of terrain #59

Closed clhenrick closed 8 years ago

clhenrick commented 8 years ago

For example in Switzerland @ #7/46.294/11.920:

screen shot 2016-07-03 at 11 10 19 am

Simple fix would be to bump up halos on all labels, though it might look odd in areas with little to no terrain. Thoughts @almccon ?

almccon commented 8 years ago

I think slightly bigger halos will be fine everywhere. The Alps are also reminding me that we might want to town down the hillshade compositing a little bit. Does it feel like the highlights are too white and the shadows too black?

clhenrick commented 8 years ago

Agreed. Yes I think toning it down a bit would be helpful as well.

clhenrick commented 8 years ago

z10+ labels have good halos: screen shot 2016-07-05 at 10 11 10 am

<= z9 halos appear to be reduced / removed for some reason: screen shot 2016-07-05 at 10 11 16 am

almccon commented 8 years ago

There are some halo radii defined here: https://github.com/stamen/terrain-classic/blob/feea30ed912f0a2e6f7de492df6a242e8f56899f/labels.mss#L29-L32 but I'm not sure which labels actually use them.

If those cities are Aries labels, then here is the jump between z9 and z10 you're seeing: https://github.com/stamen/terrain-classic/blob/feea30ed912f0a2e6f7de492df6a242e8f56899f/labels.mss#L681-L695

Maybe the lower zoom halos just need to be beefed up.

clhenrick commented 8 years ago

After 1265f7f labels are looking like so: screen shot 2016-07-05 at 2 31 39 pm screen shot 2016-07-05 at 2 31 22 pm

almccon commented 8 years ago

Love it!